This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
fix(polyfill): JSON responses were not marked as ready on complete #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI react-native-fetch-blob has a new maintained location. Check out the README. Please consider submitting your PR there, this repository is unmaintained. NOTE: Patches should be against the current development branch, not against |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XMLHttpRequestpolyfills fails to dispatch the ready state changes,and all related logic as to when a response is complete when the response
type is JSON. For some reason, the logic involved was never invoked, and
I can only assume is an oversight. I'd like to know if there wasn't any
particular reasoning, as I'll be using this version regardless in my fork,
since it solves #563 for me.